Clean-up Resource for Arrow 2.0 #2786

nomisRev · 2022-08-03T06:53:03Z

This PR cleans up old code in Resource, and fully utilises the Dsl implementation as the underlying impl for Resource. Eliminating the need for the other ADT cases, simplifying the runtime and removing the need for a use runloop.

Removed APIs

zip: composing resource using resource { f(bind(), bind()) } supports arity-n
map/tap/flatMap: the signatures are about the same length, making them feel redundant for alias.

resA.flatMap {
  resB
}

resource {
  resA.bind()
  resB.bind()
}

resA.map(f)
resource { f(resA.bind()) }

resA.tap(f)
resource { resA.bind().also(f) }

New APIs / API changes

The Resource API now also includes a DslContext duality. Meaning we have top-level APIs that return a Resource, and we have DSL APIs which do the same but apply them inside the context of the DSL. The DSL APIs are highlighted as keywords using DslMarker.

In the example below you can see how we combine parZip with the resource DSL. And how we use release context DSL to apply the Resource inside the DSL. So we remove the need for calling bind.

If you'd extract the Resource creation from within { } you could simply assign it to a val without changing the code, and it'll be reified as a Resource.

This unifies the API from within the DSL, and outside the DSL. Whilst visually giving some IDEA aid to which is being used when.

… sv-clean-up-resource

i-walker

👏🏾 👏🏾 Thanks for these huge improvements

i-walker · 2022-08-03T21:20:50Z

arrow-libs/fx/arrow-fx-coroutines/src/jvmMain/kotlin/arrow/fx/coroutines/ResourceExtensions.kt

+  timeout: Duration = Duration.INFINITE,
+  closingDispatcher: CoroutineDispatcher = Dispatchers.IO,
+  create: suspend () -> ExecutorService,
+): Resource<CoroutineContext> =


way more refined 👏🏾

… sv-clean-up-resource

i-walker · 2022-08-08T19:21:51Z

arrow-libs/fx/arrow-fx-coroutines/src/commonMain/kotlin/arrow/fx/coroutines/Resource.kt

-      acquire: suspend () -> A,
-      release: suspend (A, ExitCase) -> Unit,
-    ): Resource<A> = Allocate(acquire, release)
+public fun <A> resource(block: suspend ResourceScope.() -> A): Resource<A> = block


i-walker

The type alias Resource definition is 🔥 as well as functions like use, resource and other internals

raulraja

a great improvement to Resource ergonomics 💘

nomisRev · 2022-08-09T12:36:00Z

Design doc:

The internal implementation of Resource has heavily changed, and the public API has been adjusted to be in line with the DSL oriented changes we're making for Arrow 2.0.

Original impl

The Arrow 1.x Resource was originally implemented based on an ADT, and a tailrec interpreter but this is complex to implement. Hard to understand, and often doesn't play nice with types and IDEA etc.
Secondly, this forced us to use flatMap etc like APIs.

Impl 2

The second implementation was inspired by Effect, and featured a DSL for writing Resource based programs.
This was/is an in between solution, since this replaced the Defer and Bind cases of the ADT which could now be implemented in terms of the DSL.

This leaves us with only 2 ADT cases. Allocate and DSL.
While DSL sequences the functions and keeps track of finalisers, and Allocate binds the resources and stores the finalisers inside the DSL.

Impl 3 (Arrow 2.0)

The DSL now implements Allocate in its algebra, and this completely removes the need for Allocate case.

This however opened the door to easily create incorrect sequenced resources, if we remember that acquire is NonCancellable you can easily make the entirety of the DSL NonCancellable by doing:

val resourceA: Resource<A> = resource { /* HUGE resource program */ }
resource {
   resource({
     resourceA.bind() // We make the entirety of resourceA uncancellable. DOES NOT COMPILE!
   }) { _, exitCase -> }.bind() 
}

This however is solved by leveraging @DSLMarker. While the previous "mistake" is still possible, the user would have to force himself to make this mistake. See below.

resource { outerScope ->
   resource({
      with(outerScope) {
        resourceA.bind() // We make the entirety of resourceA uncancellable. This example does compile.
     }
   }) { _, exitCase -> }.bind() 
}

So we consider this issue fixed, since it's not easily possible for a user to create an incorrect resource.
Now that it only exists out of a single case, we can use typealias Resource<A> = suspend ResourceScope.() -> A as the definition.

Naming

The naming is just an arbitrary proposal!! Other things on the table have been Managed<A> & Manage. Resource is also still on the table, but we'd should find a better name than ResourceScope for the DSL. Any other suggestions very welcome 🙏

Since the API has changed so much, and the internals have also changed quite a bit. I thought it would be useful to evaluate the naming again. I've updated the docs to use Scope and Scoped.
Where Scoped is the lazy version of a scope... 😅

So scoped returns suspend Scope.() -> A,
and scope executes a Scoped<A> so it returns A.

The lazy version is something that typically would not be used anymore. It's a pattern common in other language, for example Scala to assign functions to val but in Kotlin that is in general not that useful. So the following pattern is advised in the docs.

suspend fun Scope.executor(): ExecutorCoroutineDispatcher =
  fixedThreadPoolContext(16, "MyDatabasePool")

suspend fun Scope.dataSource(): DataSource =
  install({ DataSource(...) }) { ds, _ -> withContext(Dispatchers.IO) { ds.close() } }
  
fun main(): Unit = runBlocking {
  scope {
    val ctx = executor()
    val ds = dataSource()
    // program
  }
}

This result in much nicer code, and IMO much more readable. From the point of the caller you can just use this as regular code, they only need to be aware that it needs to be wrapped in scope.

serras · 2022-08-09T13:29:04Z

Just my opinion: I think Resource<A> is a good name, especially because resourceA.use { ... } maps very clearly to "I'm using a resource". But maybe ManagedScope works a bit better than ResourceScope...

nomisRev · 2022-08-09T14:07:57Z

Thanks for sharing your thoughts @serras 🙌

I think Resource is a good name, especially because resourceA.use { ... } maps very clearly to "I'm using a resource".

I agree, and Kotlin Std also has use for A : Closeable and A : AutoCloseable, but I removed use from the codebase because I wanted to start from scratch..
suspend Scope.() -> A is not really a Resource anymore, but represents a suspend computation that can install n resources and produces a value of A. Not sure if that is really important though for the naming.

The idea was that you would never need use anymore, but would encode your program using regular functions.
Using either Scope as a receiver, or as a context(Scope), this DSL makes use a bit obsolete.

suspend fun <A, B> Scoped<A>.use(f: suspend (A) -> B): B = scope { f(bind()) }

Not saying we have to go with these drastic changes, but I do like the idea of just being able to write top-level functions for writing resource safe programs. And ofc we can already do the same today:

suspend fun ResourceScope.executor(): ExecutorCoroutineDispatcher = 
  Resource.fromCloseable { ... }.bind()

But maybe ManagedScope works a bit better than ResourceScope...

I like ManagedScope over ResourceScope but I think we should drop the Scope postfix like we did for EffectScope -> Shift. Renaming it after the abstract install also doesn't yield a nice name, "Installable"... I also thought of Impervious as in "leak proof", but found it too difficult word in English so I didn't even list it below.

typealias Resource<A> = suspend ManagedScope.() -> A
typealias Resource<A> = suspend Managed.() -> A
typealias Resource<A> = suspend Installable.() -> A

I really like this new API, even without use but naming it is super hard IMO.

nomisRev · 2022-08-09T14:49:42Z

@serras, I can also revert the naming changes and then we can keep this PR contained to the API.
All new signatures can be back-ported to 1.1.x, and then we can still evaluate the naming changes later on.

That would at least help speed up this PR, and would allow us to get a better feel for some of the APIs. WDYT?

serras · 2022-08-09T16:28:34Z

I really like your plan of back porting things to Arrow 1.x, to give people a feeling of the new API. Ultimately people have to learn some naming, so keeping the current one is also a good choice 👍

nomisRev · 2022-08-09T16:41:05Z

Yes, that makes more sense. I’m going to revert the naming changes 👍

… sv-clean-up-resource

nomisRev · 2022-08-16T12:11:37Z

@serras, not to block this PR but I have given this some more thought on the naming and I am back to leaning for Scope 😅

My rationale being the following:
suspend Scope.() -> A offers similar DSL to suspend CoroutineScope.() -> A but where CoroutineScope only scopes Coroutine, Scope is a high-level abstraction that can model any Scope.

For example the CoroutineScope DSL can be derived from Scope:

context(Scope)
suspend fun coroutineScope(context: CoroutineContext): CoroutineScope =
  install({ CoroutineScope(context + Job()) }) { scope, ex ->
    when (ex) {
      ExitCase.Completed -> Unit
      is ExitCase.Cancelled -> scope.coroutineContext.job.cancel(cause = exitCase.exception)
      is ExitCase.Failure -> scope.coroutineContext.job.cancel(CancellationException(ex.failure.message, ex.failure))
    }
  }.bind()

suspend fun <A> coroutineScope(block: suspend CoroutineScope.() -> A): A = scope {
  val coroutineScope = coroutineScope(currentCoroutineContext())
  return block(coroutineScope).also {
    // Await all children jobs to complete
    coroutineScope.coroutineContext.job.children.forEach { it.join() }
  }
}

WDYT? Scope seems like a good name to me since Resource seems only a subset of the functionality this offers. Although you might also argue that all use-cases it covers are related to "resource management" 🤔but the scope name is something we already know from other parts in the Kotlin eco-system... I'm really jumping back-and-forth 😅

serras · 2022-08-16T12:56:09Z

In my mind it makes sense forScope to relate to resources, since any structured management of concurrency/threads/resources is somehow tied to managing the scopes where things are visible.

If I understand correctly, though, the naming was reversed to keep compatibility with the 1.x branch. To me backporting this PR feels less important than having a nice API in Arrow 2.x, but we can also put some changes in main and have this PR target arrow-2 and change names.

i-walker · 2022-08-16T12:56:31Z

I am also in favour of Scope given the points mentioned above

nomisRev · 2022-08-16T13:10:42Z

To me backporting this PR feels less important than having a nice API in Arrow 2.x

Agreed, but most of these APIs can be very easily back ported to 1.x.x with minimal changes, and without breaking binary compatibility. That's why I suggested it. The sooner we can promote better APIs the better I think, unless it requires a lot effort or maintenance.

I just wanted to share my internal "struggle" with the naming 😅

If I understand correctly, though, the naming was reversed to keep compatibility with the 1.x branch
This was done to unblock this PR. A potential name change can be unrelated to the implementation change.

But I think the review from @raulraja, and @i-walker were outdated. I requested re-review, and when approved this can be merged.

serras

LGTM

raulraja

👏

i-walker

🙌🏾 🎊 Thanks for this. It is a great improvement

* Flatten Resource ADT, maintain API

* The beginning of Arrow 2.0 * Resource Arrow 2.0 (#2786) * Flatten Resource ADT, maintain API * [Arrow 2.0] Effect without suspending shift (#2797) * Shift without suspend, inline all the rest * Add new error handlers signatures * Make ShiftCancellationException private * Rename Shift to Raise according to Slack Poll, and add some initial docs (#2827) * Remove all references to shift from new Arrow 2.0 code (#2834) * Remove all references to shift from new code * Update API files * Fixes merge conflict between main and arrow-2 (#2835) * Add Resource.allocated() to decompose Resource into it's allocate and… (#2820) * [2743] Migrate internal use of CircuitBreaker double to duration (#2748) * Fix typo (#2824) * Make the server disconnect test more general (#2822) * Update NonEmptyList.fromList deprecation to suggest `toOption()` instead (#2832) * Improve Either.getOrHandle() docs (#2833) * Improve allocated, and fix knit examples Co-authored-by: Jeff Martin <jeff@custommonkey.org> Co-authored-by: Martin Moore <martinmoorej@gmail.com> Co-authored-by: valery1707 <valery1707@gmail.com> Co-authored-by: Lukasz Kalnik <70261110+lukasz-kalnik-gcx@users.noreply.github.com> Co-authored-by: stylianosgakis <stylianos.gakis98@gmail.com> * Add Atomic module, and StateShift (#2817) * Two small deprecations * Add Atomic module, and StateShift. Implement ior through StateShift * Fix build * Fix atomic knit * Fix knit attempt #2 * Update API files * Remove references to shift * Change return type of raise to Nothing (#2839) * Change return type of raise to Nothing Implements #2805 * Update public api with ./gradlew apiDump * Suppress warnings for unreachable calls to fail in tests The test is verifying that no code will be executed after a call to raise, so it's actually testing the very behaviour that the compiler is warning us about. Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update API files * Increase timeout * Fix compiler bug with nested inline + while + return * Clean up ExitCase.fromError * Update API files@ * Feature/remove validated (#2795) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Remove CancellationExceptionNoTrace.kt after merge, and run apiDump * Add missing runnerJUnit5 for arrow-atomic JVM * Publish Arrow 2.0.0-SNAPSHOT (#2871) Co-authored-by: Javier Segovia Córdoba <7463564+JavierSegoviaCordoba@users.noreply.github.com> * Simplify optics to Traversal/Optional/Lens/Prism (#2873) * 'mapOrAccumulate' for Raise (#2872) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> * Fix problems with Atomic * Smaller timeouts * Remove Tuple10 to Tuple22, Const, Eval, computation blocks, and arrow-continuations (#2784) * Revert typo * Fix build * Fix ParMapJvmTest * Implement NonEmptyList using value class (#2911) * Fix merge w.r.t. Saga * apiDump * Test other return expression * change unalign signature (#2972) see discussion in #2960 (comment) #2960 (comment) --------- Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update after merge main * Fix :arrow-optics-ksp-plugin:compileKotlin * Fix Every instances * Move functions to arrow functions (#3014) * Bring back `Iso` (#3013) * Bring back Iso * API Dump --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Update BOM (#3019) * Fix andThen duplication (#3020) * Fix Knit * Fix weird problem with value classes * Update API docs * Update publish workflow Following the instructions in #3090 (comment) * No closing repo on snapshot * knit * Fix optics tests * Fix after merge * Refactor ParMapTest from Kotest Plugin to Kotlin-test runtime #3191 (#3221) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Refactor: Use Kotlin-test runtime for arrow-fx-stm tests (#3224) Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update all Gradle files to mention kotlin.test * Refactor ParZip2Test from Kotest Plugin to Kotlin-test runtime #3192 (#3222) Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Refactor ParZip3Test from Kotest Plugin to Kotlin-test runtime #3193 (#3223) Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Refactor GuaranteeCaseTest to use kotlin test (#3226) Closes #3190 * refactor: migrate NotEmptySetTest to kotlin-test (#3230) Co-authored-by: Alejandro Serrano <trupill@gmail.com> * refactor: migrate EagerEffectSpec to kotlin-test (#3233) Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Refactor NullableSpec from Kotest Plugin to Kotlin-test runtime (#3236) #3153 Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Refactor BracketCaseTest to use kotlin test (#3237) Closes #3186 Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Move arrow-functions tests to kotlin.test (#3243) * Inline `AtomicBoolean` (#3240) * Inline AtomicBoolean * Update API files --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * refactor: migrate MappersSpec to kotlin-test (#3248) * Refactor ResourceTestJvm from Kotest Plugin to Kotlin-test runtime (#3244) Closes #3213 * refactor: migrate FlowJvmTest to Kotlin-test (#3228) * Refactor ParZip9JvmTest from Kotest Plugin to Kotlin-test runtime (#3245) Closes #3211 * Refactor ParZip8JvmTest from Kotest Plugin to Kotlin-test runtime (#3246) Closes #3210 * refactor: migrate NumberInstancesTest to kotlin-test (#3232) * refactor: OptionTest to kotlin-test runtime (#3229) * Revert "Inline `AtomicBoolean` (#3240)" (#3279) This reverts commit a6f1e73. * Refactor ParZip6JvmTest from Kotest Plugin to Kotlin-test runtime (#3255) Closes #3208 * Refactor ParZip5JvmTest from Kotest Plugin to Kotlin-test runtime (#3256) Closes #3207 * Refactor ParZip3JvmTest from Kotest Plugin to Kotlin-test runtime (#3258) Closes #3205 * Refactor ParZip2JvmTest from Kotest Plugin to Kotlin-test runtime (#3259) Closes #3204 * Refactor ParMapJvmTest from Kotest Plugin to Kotlin-test runtime (#3260) Closes #3203 * Refactor ParZip4JvmTest from Kotest Plugin to Kotlin-test runtime (#3257) Closes #3206 * refactor: migrate RaiseAccumulateSpec to kotlin-test (#3250) * Refactor ParZip7JvmTest from Kotest Plugin to Kotlin-test runtime (#3247) Closes #3209 Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update ComparisonKtTest.kt (#3274) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> * Update OptionSpec.kt (#3271) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> * Update TraceJvmSpec.kt (#3276) * Update TraceJvmSpec.kt * Update TraceJvmSpec.kt --------- Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> * Update ParZip9Test.kt (#3265) * Update ParZip9Test.kt * Update ParZip9Test.kt * Update ParZip8Test.kt (#3266) * Update ParZip7Test.kt (#3267) * Update ParZip6Test.kt (#3268) * Update ParZip5Test.kt (#3269) * Update ParZip4Test.kt (#3270) * Refactor CountDownLatchSpec and CyclicBarrierSpec to use kotlin test (#3227) * Refactor CountDownLatchSpec to use kotlin test Closes #3187 * Refactor CyclicBarrierSpec to use kotlin test Closes #3188 --------- Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Refactor NonEmptyListTest to kotlin-test (#3231) * Add kotlin test dependency * Refactor NonEmptyList Test to use kotlin test --------- Co-authored-by: Alejandro Serrano <trupill@gmail.com> * refactor: migrate EffectSpec to kotlin-test (#3234) * Refactor FlowTest to use kotlin test (#3238) Closes #3189 Co-authored-by: Alejandro Serrano <trupill@gmail.com> * refactor: migrate IorSpec to kotlin-test (#3249) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> * refactor: migrate ResultSpec to kotlin-test (#3251) Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> * refactor: migrate StructuredConcurrencySpec to kotlin-test (#3252) * refactor: migrate TraceSpec to kotlin-test (#3253) * refactor: migrate GeneratorsTest to kotlin-test (#3254) * Refactor RaceNJvmTest from Kotest Plugin to Kotlin-test runtime (#3261) Closes #3212 Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update ArrowResponseEAdapterTest.kt (#3264) * Update ArrowResponseEAdapterTest.kt * Update ArrowResponseEAdapterTest.kt --------- Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update CollectionsSyntaxTests.kt (#3273) * Update CollectionsSyntaxTests.kt * Update CollectionsSyntaxTests.kt --------- Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> Co-authored-by: Alejandro Serrano <trupill@gmail.com> * Update NonFatalJvmTest.kt (#3277) * Update ArrowEitherCallAdapterTest.kt (#3278) * Update ArrowEitherCallAdapterTest.kt * Update ArrowEitherCallAdapterTest.kt * Move tests from `serialization` and `functions` completely to `kotlin.test` (#3289) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix problems with tests * Remove a bunch of warnings in `arrow-2` (#3282) Co-authored-by: serras <serras@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Finish transition to `kotlin.test` of `retrofit` and `fx-coroutines` (#3291) * Fix problems with concurrency in tests, take 8 * Port rest of `arrow-core` to `kotlin.test` (#3292) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Implement `fixedRate` using monotonic time source (#3294) Co-authored-by: serras <serras@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Port `optics` tests to `kotlin.test` (#3295) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Add or fix contracts in Raise (#3293) * Add or fix contracts in Raise * Make contracts less strict * Get back contract on Either * ignoreErrors should also be AT_MOST_ONCE --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Alternate `SingletonRaise` (#3328) Co-authored-by: Youssef Shoaib <canonballt@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: serras <serras@users.noreply.github.com> * Remove (unused) tests for high-arity module * Fix tests + Knit * Fix merge NullableSpec * Regression in Arb.list? * Fix test for nonEmptyList * Develocity warning * Fix merge problem with optics-ksp-plugin * Fix timeout in test --------- Co-authored-by: Simon Vergauwen <nomisRev@users.noreply.github.com> Co-authored-by: Sam Cooper <54266448+roomscape@users.noreply.github.com> Co-authored-by: Marc Moreno Ferrer <ignis.fatue@gmail.com> Co-authored-by: Javier Segovia Córdoba <7463564+JavierSegoviaCordoba@users.noreply.github.com> Co-authored-by: Alphonse Bendt <370821+abendt@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andreas Storesund Madsen <andreas@asmadsen.no> Co-authored-by: molikuner <molikuner@gmail.com> Co-authored-by: Jonathan Lagneaux <lagneaux.j@gmail.com> Co-authored-by: Marcus Ilgner <mail@marcusilgner.com> Co-authored-by: Chris Black <2538545+chrsblck@users.noreply.github.com> Co-authored-by: Tejas Mate <hi.tejas@pm.me> Co-authored-by: HyunWoo Lee (Nunu Lee) <54518925+l2hyunwoo@users.noreply.github.com> Co-authored-by: serras <serras@users.noreply.github.com> Co-authored-by: Youssef Shoaib <canonballt@gmail.com>

Clean-up Resource for 2.0

5ef430d

nomisRev requested review from i-walker, raulraja, serras and a team August 3, 2022 06:53

nomisRev added the 2.0.0 Tickets / PRs belonging to Arrow 2.0 label Aug 3, 2022

nomisRev mentioned this pull request Aug 3, 2022

Arrow 2.0 #2778

Merged

20 tasks

Update API files

70031b3

nomisRev self-assigned this Aug 3, 2022

nomisRev added 4 commits August 3, 2022 11:58

Fix build, rewrite some tests and make more DSL improvements

de73b43

Merge branch 'sv-clean-up-resource' of github.com:arrow-kt/arrow into…

d62f65c

… sv-clean-up-resource

Update API files

c82589a

Merge branch 'arrow-2' into sv-clean-up-resource

63cc6b0

i-walker approved these changes Aug 3, 2022

View reviewed changes

nomisRev added 5 commits August 8, 2022 17:48

Flatten Resource further, maintain API

852d118

Update API files

c5da87b

Merge branch 'arrow-2' into sv-clean-up-resource

95d0eac

Update docs

31ae2db

Merge branch 'sv-clean-up-resource' of github.com:arrow-kt/arrow into…

11c5196

… sv-clean-up-resource

i-walker reviewed Aug 8, 2022

View reviewed changes

i-walker approved these changes Aug 8, 2022

View reviewed changes

raulraja approved these changes Aug 8, 2022

View reviewed changes

nomisRev added 2 commits August 10, 2022 08:44

Rename to old naming

a30a452

Update API files

b9a84e5

nomisRev mentioned this pull request Aug 10, 2022

Missing documentation for Validated #2796

Closed

nomisRev added 2 commits August 10, 2022 11:17

apiDump

56026e5

Merge branch 'sv-clean-up-resource' of github.com:arrow-kt/arrow into…

0796aeb

… sv-clean-up-resource

nomisRev requested review from raulraja and i-walker August 16, 2022 13:08

serras approved these changes Aug 31, 2022

View reviewed changes

raulraja approved these changes Aug 31, 2022

View reviewed changes

i-walker approved these changes Sep 1, 2022

View reviewed changes

nomisRev merged commit cfd44d9 into arrow-2 Sep 1, 2022

nomisRev deleted the sv-clean-up-resource branch September 1, 2022 12:09

nomisRev added a commit that referenced this pull request Sep 3, 2022

Resource Arrow 2.0 (#2786)

cc8a9fd

* Flatten Resource ADT, maintain API

nomisRev mentioned this pull request Sep 8, 2022

Add Resource.allocated() to decompose Resource into it's allocate and… #2820

Merged

nomisRev mentioned this pull request Nov 16, 2022

Resource API deprecation, and preparation for 2.x.x. & back port improvements #2847

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean-up Resource for Arrow 2.0 #2786

Clean-up Resource for Arrow 2.0 #2786

nomisRev commented Aug 3, 2022 •

edited

Loading

i-walker left a comment

i-walker Aug 3, 2022

i-walker Aug 8, 2022

i-walker left a comment

raulraja left a comment

nomisRev commented Aug 9, 2022

serras commented Aug 9, 2022

nomisRev commented Aug 9, 2022 •

edited

Loading

nomisRev commented Aug 9, 2022

serras commented Aug 9, 2022

nomisRev commented Aug 9, 2022

nomisRev commented Aug 16, 2022 •

edited

Loading

serras commented Aug 16, 2022

i-walker commented Aug 16, 2022

nomisRev commented Aug 16, 2022 •

edited

Loading

serras left a comment

raulraja left a comment

i-walker left a comment

Clean-up Resource for Arrow 2.0 #2786

Clean-up Resource for Arrow 2.0 #2786

Conversation

nomisRev commented Aug 3, 2022 • edited Loading

Removed APIs

New APIs / API changes

i-walker left a comment

Choose a reason for hiding this comment

i-walker Aug 3, 2022

Choose a reason for hiding this comment

i-walker Aug 8, 2022

Choose a reason for hiding this comment

i-walker left a comment

Choose a reason for hiding this comment

raulraja left a comment

Choose a reason for hiding this comment

nomisRev commented Aug 9, 2022

Original impl

Impl 2

Impl 3 (Arrow 2.0)

Naming

serras commented Aug 9, 2022

nomisRev commented Aug 9, 2022 • edited Loading

nomisRev commented Aug 9, 2022

serras commented Aug 9, 2022

nomisRev commented Aug 9, 2022

nomisRev commented Aug 16, 2022 • edited Loading

serras commented Aug 16, 2022

i-walker commented Aug 16, 2022

nomisRev commented Aug 16, 2022 • edited Loading

serras left a comment

Choose a reason for hiding this comment

raulraja left a comment

Choose a reason for hiding this comment

i-walker left a comment

Choose a reason for hiding this comment

nomisRev commented Aug 3, 2022 •

edited

Loading

nomisRev commented Aug 9, 2022 •

edited

Loading

nomisRev commented Aug 16, 2022 •

edited

Loading

nomisRev commented Aug 16, 2022 •

edited

Loading